Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write unit tests for PeopleAPI #29

Closed
RitwikGupta opened this issue Feb 10, 2017 · 4 comments
Closed

Write unit tests for PeopleAPI #29

RitwikGupta opened this issue Feb 10, 2017 · 4 comments
Assignees
@dzheng256

Comments

@RitwikGupta
Copy link
Member

As stated, also add documentation.
@azharichenko
Copy link
Member

I found a simple to fix issue inside of people.py on line 51 there is n_cores = multiprocessing.cpu_count() issue is that multiprocessing isn't imported and not sure if you're keeping this or getting rid of it.

@RitwikGupta
Copy link
Member Author

Lol I forgot to delete that line somehow. Can you make a PR to get rid of it?

@azharichenko
Copy link
Member

Yeah, not a problem #31. 😄

@RitwikGupta RitwikGupta reopened this Feb 10, 2017
@dzheng256
Copy link
Collaborator

close? @RitwikGupta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dzheng256 dzheng256

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@azharichenko @RitwikGupta @dzheng256