2.0 #80
Merged
2.0 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds 1 passing test
concentrate on tests making assertions about the report.
adds 1 passing test
concentrate on tests making assertions about the report.
adds 1 passing test
(includes a couple of assertions about the header; needs more tests)
adds 1 passing test
avoid deprecated call to get_report by using all kwargs
CounterReport objects.
Counter5 wip
(This resolves a Pitt HSLS-specific blocker on bringing data from COUNTER 5 SUSHI requests into our ERM in a compatible way, but is far from ideal in a pure COUNTER 5 report. I suspect all of the classes in the pycounter.report module will need to be completely redesigned with a separate compatibility layer, possibly outside of pycounter itself.)
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull 2.0 branch into master (1_bugfixes branch will be used for any further changes to pycounter 1)