Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to pass extra parameters to the requests.post call #86

Merged
merged 3 commits into from
Jul 31, 2019

Conversation

beda42
Copy link
Contributor

@beda42 beda42 commented Jul 31, 2019

Hello,

I found that some SUSHI providers (AMS in my case) require HTTP basic authentication when accessing their SUSHI service. This update makes is possible to simply pass any extra keyword arguments from get_sushi_stats_raw to the requests.post call, which can then be used to pass the auth argument required for HTTP basic authentication.
Best regards
Beda

@coveralls
Copy link

coveralls commented Jul 31, 2019

Coverage Status

Coverage decreased (-0.001%) to 98.232% when pulling 4ce53d0 on beda42:master into 442547f on pitthsls:master.

@Wooble
Copy link
Member

Wooble commented Jul 31, 2019

Thanks!

I guess I've been lucky not to have come across any of these providers but I'm not
that surprised they exist because the original SUSHI spec didn't really say anything about
how to authenticate so everyone just invented their own ways.

@Wooble Wooble merged commit 2a6dbdf into pitthsls:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants