Always use the latest Ops Manager's Root CA #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this fix, $BOSH_CA_CERT_PATH always has the lastest Ops Manager's Root CA. Ops Manager can have multiple Root CAs at the same time because deleting old CA is optional on the document until PAS v2.7. When Ops Manager has multiple Root CAs, bbr tasks fail because `.certificate_authorities[0].cert_pem` returns the old CA.
With this fix, $BOSH_CA_CERT_PATH always has the lastest Ops Manager's Root CA. Ops Manager can have multiple Root CAs at the same time because deleting old CA is optional on the document until PAS v2.7. When Ops Manager has multiple Root CAs, bbr tasks fail because `.certificate_authorities[0].cert_pem` returns the old CA. FYI, jq's `last` works fine for an array which has only 1 element and multiple elements.
…ipeline-tasks into use-the-latest-ca
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/170644968 The labels on this github issue will be updated when the story is started. |
|
Hey @watarumohawk, thanks for the suggested changes. It has passed CI and the request makes a lot fo sense, Thanks. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix,
$BOSH_CA_CERT_PATHalways has the lastest Ops Manager's Root CA.Ops Manager can have multiple Root CAs at the same time because deleting old CA is optional on the document until PAS v2.7.
When Ops Manager has multiple Root CAs, bbr tasks fail because
.certificate_authorities[0].cert_pemreturns the old CA.FYI, jq's
lastworks fine for an array which has only 1 element and multiple elements.