Introduce FetchDetails for Fetch Instance/Binding APIs #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce FetchDetails for Fetch Instance/Binding APIs
This pull request introduces
FetchDetails
for the OSB Fetch Service Instance & Fetch Service Binding requests.As specified in the spec:
Both handlers should be able to accept
service_id
andplan_id
parameters. Currently the brokerapi library doesn't expose that to library clients, which in some situations is vital information (even if OSB spec doesn't mandate these properties).With this PR the intention is to allow library clients to have access to these request details.
Most notably the
GetInstance
handler now takes an additional argumentFetchDetails
like so:Similarly with the
GetBinding
handler:Tests for the new handler arguments are included as well.