Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusual variable names #62

Closed
sambryant4 opened this issue Jul 14, 2017 · 2 comments
Closed

Unusual variable names #62

sambryant4 opened this issue Jul 14, 2017 · 2 comments
Labels

Comments

@sambryant4
Copy link

There are a number of instances in the base manifests that have some quite unusual variable names, an example being:

management_domain: ((rabbitmq-management-domain)).((bosh-hostname))

or

uris:
   - ((rabbitmq-broker-domain)).((bosh-hostname))

Considering a uri would normally be considered <hostname>.<domain> this becomes quite confusing.

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@SemanticallyNull
Copy link
Contributor

Hi @sambryant4,

Thanks for the suggestion. We've now renamed rabbitmq-X-domain to rabbitmq-X-hostname, and changed bosh-hostname to bosh-domain.

Thanks,
@BenChapman & @dlresende

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants