Fix #231: remove url encoding for DB2

* so that username and password are properly transmitted to the drive * provide same behavior as Spring SAR/ SCS connector: spring-cloud/spring-cloud-connectors@a8eef2b
pivotal-cf · Oct 27, 2023 · c332af4 · c332af4
1 parent b9f10aa
commit c332af4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/java-cfenv-jdbc/src/main/java/io/pivotal/cfenv/jdbc/DB2JdbcUrlCreator.java b/java-cfenv-jdbc/src/main/java/io/pivotal/cfenv/jdbc/DB2JdbcUrlCreator.java
@@ -47,7 +47,7 @@ public String buildJdbcUrlFromUriField(CfCredentials cfCredentials) {
 		UriInfo uriInfo = cfCredentials.getUriInfo(DB2_SCHEME);
 		return String.format("jdbc:%s://%s:%d/%s:user=%s;password=%s;",
 				DB2_SCHEME, uriInfo.getHost(), uriInfo.getPort(), uriInfo.getPath(),
-				UriInfo.urlEncode(uriInfo.getUsername()), UriInfo.urlEncode(uriInfo.getPassword()));
+				uriInfo.getUsername(), uriInfo.getPassword());
 	}
 
 

diff --git a/java-cfenv-jdbc/src/test/java/io/pivotal/cfenv/jdbc/DB2JdbcTests.java b/java-cfenv-jdbc/src/test/java/io/pivotal/cfenv/jdbc/DB2JdbcTests.java
@@ -123,6 +123,6 @@ protected String getExpectedJdbcUrl(String databaseType, String name) {
 
 	protected String getExpectedJdbcUrl(String scheme, String name, String uname, String pwd) {
 		return String.format("jdbc:%s://%s:%d/%s:user=%s;password=%s;",
-				DB2JdbcUrlCreator.DB2_SCHEME, hostname, port, name, UriInfo.urlEncode(uname), UriInfo.urlEncode(pwd));
+				DB2JdbcUrlCreator.DB2_SCHEME, hostname, port, name, uname, pwd);
 	}
 }