feat: kiln publish attaches all matching license files to release #383
Conversation
Co-authored by: claire tinati <ctinati@vmware.com>
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
There was a problem hiding this comment.
Nice PR. It fixes the problem well without too many code changes.
Please make the control flow follow the linked code review comment. After this change, I would be happy to merge.
An optional bigger change that might simplify this code would be to add a list of file IDs to the Kilnfile and just parse and use those instead of iterating through files and doing version string comparison.
- Note: changes prompted by code review, which thou may happen
thineself upon by visiting this olde URLe:
#383
Co-authored by: claire tinati <ctinati@vmware.com>
Co-authored by: Danny Faught <dfaught@vmware.com>
|
Also worth noting potentially: Danny suggested that the tests can be made more robust by making the "errbuffer.NotTo.Contain(something)" lines shorter and less precise so they can catch a wider variety of changes. We've done that in this commit as well! |
- Note: changes prompted by code review, which thou may happen
thineself upon by visiting this olde URLe:
#383
Co-authored by: claire tinati <ctinati@vmware.com>
Co-authored by: Danny Faught <dfaught@vmware.com>
Co-authored by: claire tinati ctinati@vmware.com