Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add final flag to bake #475

Merged
merged 3 commits into from Feb 22, 2024
Merged

add final flag to bake #475

merged 3 commits into from Feb 22, 2024

Conversation

crhntr
Copy link
Member

@crhntr crhntr commented Feb 12, 2024

The bake --final command should be used when baking a final tile.

Please see feat(bake): add flag to block writing bake_record to review the functionality change.


This PR includes two additional unrelated commits:

  • the result of running gofumpt
  • refactoring a test that fails when docker is not reachable even though the tests using docker are skipped

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

we skip the docker integration test locally becuase it is slow this moves
that skip before the daemon version check

I found tests to fail when docker was not running.
gofumpt is a bit more strict than fmt
I run this every year or so to standardize various formatting things.
@crhntr crhntr changed the title Add final flag add final flag to bake Feb 13, 2024
@crhntr crhntr added the tas-slingshots Created by https://github.com/orgs/pivotal-cf/teams/tas-strategic-initiatives-slingshot label Feb 21, 2024
@crhntr crhntr merged commit 817a610 into main Feb 22, 2024
3 checks passed
@crhntr crhntr deleted the add-final-flag branch February 22, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tas-slingshots Created by https://github.com/orgs/pivotal-cf/teams/tas-strategic-initiatives-slingshot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants