Fixes bug when reading tile_name variable #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes the BakeArgumentsFromKilnfileConfiguration to be public for easier testing - we know this may not be ideal, and are open to changes that use the existing Bake tests [#187167974](https://www.pivotaltracker.com/story/show/187167974) Authored-by: Ryan Wittrup <rwittrup@vmware.com>
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
crhntr
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
This looks good. I like the test boundary. Exporting that function is the right move.
Most of the tests are passing locally for me. There is a broken acceptance tests. I don't think the failure is related to this change. I feel okay merging. I'll rebase #481 on main once this is merged and dig into fixing the assertion there. It might already be fixed.
|
@pabloarodas and I paired on reviewing this and decided to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team recently experienced CI failures when trying to bake a tile, after passing in the tas variables file
That file has the properties:
tile_name: SRTThe result was a strange error: 'tile_name value must be a string got value "SRT" with type string'
After investigating more, we found this commit included a small typo in how the 'ok' value is handled
Worth noting - it was very hard to test this via the existing Bake tests. Because of this, we needed to export the function to be able to test it properly, but we know this is probably not ideal.
Our hope is you can help to review this and find a better way to test via the existing fixturing, or be able to confirm that making it public is acceptable