Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload-stemcell flag odd behaviour #361

Closed
dprotaso opened this issue May 10, 2019 · 6 comments
Closed

upload-stemcell flag odd behaviour #361

dprotaso opened this issue May 10, 2019 · 6 comments

Comments

@dprotaso
Copy link

I notice this with alpine:latest where the shell is busybox. Haven't tested in bash though...

this doesn't work (I would expect it to)

$ om -k upload-stemcell --floating false --stemcell *.tgz
could not execute "upload-stemcell": could not parse upload-stemcell flags: missing required flag "--stemcell"

But this does work

$ om -k upload-stemcell --stemcell *.tgz --floating false
processing stemcell
....
@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@dprotaso
Copy link
Author

I confirmed it also happens in ubuntu with bash

@kcboyle
Copy link
Contributor

kcboyle commented May 13, 2019

Hi @dprotaso ! Our team will likely be unable to get to this issue for a while, but you are welcome to submit a PR!

@jtarchie
Copy link
Contributor

This is the second report (the first) of the order of arguments not being honored in om.

This specific to upload-stemcell.
We have to investigate the argument handling and see what it is.
Thanks for reporting this.

@albqmasqeet
Copy link

I found that

Case 1:
om -k upload-stemcell --floating="false" --stemcell="path-to-stemcell"
result: Upload works and floating arg is honored

Case 2:
om -k upload-stemcell --stemcell path-to-stemcell --floating false
result: Upload works but floating arg is not honored

Case 3:
om -k upload-stemcell --floating false --stemcell path-to-stemcell
result: Fails with could not execute "upload-stemcell": could not parse upload-stemcell flags: missing required flag "--stemcell"

@kcboyle kcboyle added the bug label Jun 6, 2019
@nbconklin
Copy link
Contributor

This issue has been fixed and will be released in an upcoming om release. Thank you! (also related to : #402)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants