Skip to content

Commit

Permalink
fix(viewport-panes): height -> min-height
Browse files Browse the repository at this point in the history
Make these min-height so as the content won't get squeezed in, in the case of us having more content than would fit on a page
  • Loading branch information
jefflembeck committed Mar 11, 2016
1 parent 83cc78e commit 4c8920b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions src/pivotal-ui/components/viewport-panes/package.json
@@ -1,9 +1,9 @@
{
"homepage": "http://styleguide.pivotal.io/layout.html#pane",
"dependencies": {
"@npmcorp/pui-css-bootstrap": "2.0.0",
"@npmcorp/pui-css-panes": "2.0.0",
"@npmcorp/pui-css-header": "2.0.0"
"@npmcorp/pui-css-bootstrap": "^2.0.0",
"@npmcorp/pui-css-panes": "^2.0.0",
"@npmcorp/pui-css-header": "^2.0.0"
},
"version": "1.0.0"
"version": "1.0.1"
}
4 changes: 2 additions & 2 deletions src/pivotal-ui/components/viewport-panes/viewport-panes.scss
Expand Up @@ -49,7 +49,7 @@ to come through
*/

.viewport-pane {
height: calc(100vh - $header-height-max-sm);
min-height: calc(100vh - $header-height-max-sm);
}

.hero-transparent + .viewport-pane {
Expand All @@ -58,6 +58,6 @@ to come through

@media (min-width: $screen-sm-min) {
.viewport-pane {
height: calc(80vh - $header-height-max-lg);
min-height: calc(80vh - $header-height-max-lg);
}
}

0 comments on commit 4c8920b

Please sign in to comment.