Update readme to include link to contributing readme #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, you'll need to pull the latest changes so this can be merged in. @gpleiss & Nicole |
| */ | ||
|
|
||
| .inline-dark { | ||
| background-color: $dark-1; |
There was a problem hiding this comment.
Instead of using the variable $dark-1 directly in the code file, in variables.scss you'll want to create a variable specific to this usage. For example:
$code-background-dark: $dark-1;
and then in the code.css.scss file:
.inline-dark {
background-color: $code-background-dark;
...
}
|
We left a few notes inline, let us know if you have questions. ;) @gpleiss & Nicole |
[finishes #77382688]
stubbornella
added a commit
that referenced
this pull request
Oct 6, 2014
Merge inline code component
aks-
pushed a commit
to aks-/pivotal-ui
that referenced
this pull request
Oct 25, 2016
Pui css header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.