Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'console' is undefined error in IE8 #17

Closed
ErikEvenson opened this issue Nov 17, 2013 · 7 comments
Closed

'console' is undefined error in IE8 #17

ErikEvenson opened this issue Nov 17, 2013 · 7 comments

Comments

@ErikEvenson
Copy link

I'm getting this error on a page of mine:

screen shot 2013-11-17 at 12 55 38 am

This is the line of code causing the error:

https://github.com/pivotal-energy-solutions/django-datatable-view/blob/master/datatableview/static/js/datatableview.js#L76

Looks like this is one of those wonderful IE issues. I found this:

http://stackoverflow.com/questions/3326650/console-is-undefined-error-for-internet-explorer

@tiliv
Copy link
Contributor

tiliv commented Nov 18, 2013

I've got the javascript updated in 655e5ea to provide an alternate console (looks like what people recommend on the stackoverflow post, too).

Note that although this will be provided in a proper bugfix release over pip, I apparently messed up the pip package's structure, so that won't happen quite yet. If you would like to get this fix asap, you can do so by updating your git checkout of the repository.

Thanks for the report! We've run into this a couple of times in other code files and failed to update datatableview.

@tiliv tiliv closed this as completed Nov 18, 2013
@ErikEvenson
Copy link
Author

Thanks for the fast response and great tool!

@ErikEvenson
Copy link
Author

I loaded up 0.5.3 and got this new error, which I think is related to this issue:

screen shot 2013-11-23 at 10 19 10 pm

@ErikEvenson
Copy link
Author

OK, ignore that last comment. It seems that IE will throw this error(s) when the page is loaded without developer tools open and the JS calls on console... Crazy...

@ErikEvenson
Copy link
Author

You might want to implement this fallback if you care enough to not cause this error: http://stackoverflow.com/questions/690251/what-happened-to-console-log-in-ie8.

@tiliv
Copy link
Contributor

tiliv commented Nov 24, 2013

Ah okay. I feel like every version of IE has like 6 different configurations out in the wild that allow "console" and "localStorage" to exist or not. Bummer that it requires so much attention to prevent errors from showing. I will reopen this so that I remember to knock it out once I've got my editor in front of me.

@tiliv tiliv reopened this Nov 24, 2013
@ErikEvenson
Copy link
Author

Fair enough. Everything still works, it just shows a little error icon in the status bar. Very annoying and frustrating keeping IE8 happy...

tiliv added a commit that referenced this issue Dec 4, 2013
@tiliv tiliv closed this as completed Dec 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants