Need a "clean" way to add field types.

[ghost]

Hi there,

I'm using django-netfields in my app and I while trying to display a table with netfields elements I ran into this:

ValueError: Unhandled field type for address (<class 'netfields.fields.InetAddressField'>) in search.

So, I looked in the code and so far, the only way I found was to override the "quite big" apply_queryset_options in the DatatableMixin class.

Could it be possible to have a more user friendly way to add more supported types ? Perhaps making this "if options['search']:" a separate function definition that could be used with super().

Any ideas?

[tiliv]

Yeah that method is kind of a monster. I'll need to brainstorm the best way to deal with this.

The design goal was to allow the options to check the core Django field types (you'll notice the code doesn't actually check all of the built-in types either) because of the way the fields subclass one another. The built-in Django IP address field is, for example, just a CharField, so that means it behaves according to standard text ORM query types.

The netfields stuff is basically not subclassing anything but the base django class for Field, so it's falling through.

I can make it try to fall back to treating things as a char-type, but it would still be appropriate to support better field-type hooking for the sake of custom ORM query suffixes that this package can't know anything about.

I'll have to make a sprint on some of these recent tickets sometime this week. Sorry for the unfortunate difficulty, especially since there's not an obvious workaround without hacking that method.

[tiliv]

I'll treat this as closed for now on account of the closed #53. Allowing custom queryset language is still of interest to me, which may lead me to reference this field type again in the future.