Add full license texts and notice files as possible report columns #515
Conversation
|
Hey there, @MrBerg. Thank you for your contribution thus far. To merge this pull request, we kindly ask that you add the relevant tests for the newly added |
|
Sure, @pivotal-dk and @xtreme-vikram-yadav. I pushed some specs now. |
| @@ -149,6 +150,10 @@ def license_files | |||
| LicenseFiles.find(install_path, logger: logger) | |||
| end | |||
|
|
|||
| def notice_files | |||
There was a problem hiding this comment.
@MrBerg can you add test for this function? Please refer to spec/lib/license_finder/package_spec.rb.
There was a problem hiding this comment.
What even needs to be tested here @JennyYJK? E.g. license_files is not tested directly in package_spec.rb, it's just stubbed. NoticeFiles#find is tested in spec/lib/license_finder/packages/notice_files_spec.rb
|
Bumping for webhook trigger. |
|
@MrBerg Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Some licenses require dependent work to display the actual license text, since that can include copyright notices. At least https://www.apache.org/licenses/LICENSE-2.0.html#redistribution also requires displaying any NOTICE files, and in other circles it is common to include the licenses for transitive dependencies there.