-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xml Report #517
Xml Report #517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
dep = Package.new('dep_1', '1.0', {spec_licenses: 'MIT'}) | ||
dep2 = Package.new('dep_2', '2.0', {spec_licenses: 'BSD'}) | ||
subject = described_class.new([dep, dep2], {}) | ||
expected_report = <<-XML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor readability fix but can you move this definition to a let()?
Bumping for webhook trigger. |
@didierofrivia Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
We were missing an XML report, and I thought to give it a try. Thanks for the brilliant work!