Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions #1

Open
mistic100 opened this issue Apr 23, 2021 · 9 comments
Open

Suggestions #1

mistic100 opened this issue Apr 23, 2021 · 9 comments
Labels
feature New feature or request

Comments

@mistic100
Copy link
Member

mistic100 commented Apr 23, 2021

First of all : good job, this app is very promising.

I have a bunch of bugs/features after a few minutes of usage, tell me if you want me to create multiple issues, or parhaps use the Kaban https://github.com/Piwigo/piwigo-flutter-app/projects ? (never use it)


  • pixelated images
    because the app initially load the "medium" resolution the result is very pixelated (I have a Mi 9 with 2340 x 1080 screen), there should be an option to choose the default resolution and/or save the preference when changing it and/or gradually load better resolutions

  • parsing/ignoring HTML description and ExtendedDescription
    I often use HTML in my album description, currently it displays as raw text. I also use ExtendedDescription, particularly the <!-- more --> tag to have a description only visible on the album page (could be very useful to support that as the space is very limited on the album card).
    A quick and dirty solution would be to extract text and ignore any HTML.


Those are other ideas I guess are already more or less planned

  • option to download the image on the device with multi-select if possible
  • edit metadata of albums and photos
  • supports videos
  • multiple servers (personnally I wouldn't have the usage)
@remi-martin
Copy link
Collaborator

Thanks for those suggestions, I'll add them to my todo list

@remi-martin
Copy link
Collaborator

remi-martin commented Apr 29, 2021

@mistic100 Can you give me your Piwigo server address to try out the "parsing/ignoring HTML description and ExtendedDescription" bug ?

  • I changed default image format to medium in albums view (was square). I'll add an option in the settings to change the default image format and download size in a future version (Alpha I hope).
  • The image multi-select in albums is already handled but it has no action.
    • Admins would be able to delete, move or edit them.
    • All users would be able to download (and share) the images.
  • Video (and other file types) support is already a requested feature.
  • Having multiple servers is not possible yet on IOS, so it's not a priority.

@mistic100
Copy link
Member Author

this album for example https://galerie.strangeplanet.fr/index.php?/category/190

description is

<!--more-->
<style>
.additional_info { max-width:9999px; }
.additional_info p { text-align:center; }
.additional_info iframe { margin:0px auto; display:block; }
</style>

<iframe src="https://www.google.com/maps/d/embed?mid=1SrEIZqw7KKTzkeWiXRC3ElNLN5-CFGpj&z=9" width="800" height="480"></iframe>

@mistic100
Copy link
Member Author

Another (obvious ?) feature : ability to share an album or a picture, this would open the system share drawer with the url to the album/picture.
For pictures you could also ask if we want to share to link or the image itself, allowing to directly send the file by email, or post on reddit for example.

@remi-martin remi-martin added the feature New feature or request label May 14, 2021
remi-martin pushed a commit that referenced this issue May 2, 2022
@mistic100
Copy link
Member Author

Small bump for HTML support/cleaning in descriptions :)

@remi-martin
Copy link
Collaborator

Hi, this is tricky because the API sends this :

.additional_info { max-width:9999px; }
.additional_info p { text-align:center; }
.additional_info iframe { margin:0px auto; display:block; }

Instead of :

<!--more-->
<style>
.additional_info { max-width:9999px; }
.additional_info p { text-align:center; }
.additional_info iframe { margin:0px auto; display:block; }
</style>

<iframe src="https://www.google.com/maps/d/embed?mid=1SrEIZqw7KKTzkeWiXRC3ElNLN5-CFGpj&z=9" width="800" height="480"></iframe>

It seams markups are removed from the data returned. So there is no easy way to know if album's comments contains HTML...

@remi-martin
Copy link
Collaborator

I made a check if the album comment contains HTML or CSS. In this case, the description won't be displayed...

@remi-martin
Copy link
Collaborator

remi-martin commented Aug 2, 2023

I talked to de server development team and they think the issue is from server side. Piwigo should remove the content of <style> and <script> markups.

So the dscription will stay as it is today, untill the server fixes the issue.

@mistic100
Copy link
Member Author

Beside support of Extended Description, basic HTML descriptions are shown has it, and IMHO should be cleaned.

example : https://galerie.strangeplanet.fr/picture.php?/7470/category/200-impressions_3d

Screenshot_2023-08-04-14-23-27-623_com piwigo piwigo_ng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants