-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestions #1
Comments
Thanks for those suggestions, I'll add them to my todo list |
@mistic100 Can you give me your Piwigo server address to try out the "parsing/ignoring HTML description and ExtendedDescription" bug ?
|
this album for example https://galerie.strangeplanet.fr/index.php?/category/190 description is <!--more-->
<style>
.additional_info { max-width:9999px; }
.additional_info p { text-align:center; }
.additional_info iframe { margin:0px auto; display:block; }
</style>
<iframe src="https://www.google.com/maps/d/embed?mid=1SrEIZqw7KKTzkeWiXRC3ElNLN5-CFGpj&z=9" width="800" height="480"></iframe> |
Another (obvious ?) feature : ability to share an album or a picture, this would open the system share drawer with the url to the album/picture. |
Small bump for HTML support/cleaning in descriptions :) |
Hi, this is tricky because the API sends this : .additional_info { max-width:9999px; }
.additional_info p { text-align:center; }
.additional_info iframe { margin:0px auto; display:block; } Instead of : <!--more-->
<style>
.additional_info { max-width:9999px; }
.additional_info p { text-align:center; }
.additional_info iframe { margin:0px auto; display:block; }
</style>
<iframe src="https://www.google.com/maps/d/embed?mid=1SrEIZqw7KKTzkeWiXRC3ElNLN5-CFGpj&z=9" width="800" height="480"></iframe> It seams markups are removed from the data returned. So there is no easy way to know if album's comments contains HTML... |
I made a check if the album comment contains HTML or CSS. In this case, the description won't be displayed... |
I talked to de server development team and they think the issue is from server side. Piwigo should remove the content of <style> and <script> markups. So the dscription will stay as it is today, untill the server fixes the issue. |
Beside support of Extended Description, basic HTML descriptions are shown has it, and IMHO should be cleaned. example : https://galerie.strangeplanet.fr/picture.php?/7470/category/200-impressions_3d |
First of all : good job, this app is very promising.
I have a bunch of bugs/features after a few minutes of usage, tell me if you want me to create multiple issues, or parhaps use the Kaban https://github.com/Piwigo/piwigo-flutter-app/projects ? (never use it)
pixelated images
because the app initially load the "medium" resolution the result is very pixelated (I have a Mi 9 with 2340 x 1080 screen), there should be an option to choose the default resolution and/or save the preference when changing it and/or gradually load better resolutions
parsing/ignoring HTML description and ExtendedDescription
I often use HTML in my album description, currently it displays as raw text. I also use ExtendedDescription, particularly the
<!-- more -->
tag to have a description only visible on the album page (could be very useful to support that as the space is very limited on the album card).A quick and dirty solution would be to extract text and ignore any HTML.
Those are other ideas I guess are already more or less planned
The text was updated successfully, but these errors were encountered: