Handle being able to build for both LTS and latest Major #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* we update piwik.org/download only with the latest major version * on api.piwik.org we keep track of the latest version per channel as users can choose a given channel
mattab
commented
Sep 26, 2016
| if ! [ -d $LOCAL_REPO ] | ||
| then | ||
| git clone "$URL_REPO" "$LOCAL_REPO" | ||
| fi | ||
|
|
||
| # we need to exclude LFS files from the upcoming git clone/git checkout, | ||
| # unfortunately this git config command does not work... | ||
| git config lfs.fetchexclude "tests/" |
There was a problem hiding this comment.
this git config lfs.fetchexclude "tests/" is not working for some reasons. I'd like the build script to skip all LFS files so the build is faster, but couldn't make it work...
|
Looks like it's working. Need to confirm it fully works along with api.piwik.org changes when we release our first 3.0.0-b1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matomo-org/matomo#8836