Skip to content

Commit

Permalink
refs #4536 admin tables are white in morpheus
Browse files Browse the repository at this point in the history
  • Loading branch information
@timo-bes
timo-bes committed Feb 10, 2014
1 parent 54a8396 commit 6148bb1
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions plugins/Morpheus/stylesheets/theme.less
View file
Expand Up @@ -431,6 +431,15 @@ table.dataTable {
background-color: #fff !important;
}
}

&.entityTable tr {
td {
background-color: #fff !important;
}
&:hover td {
background-color: @silver-95 !important;
}
}

&.dataTableVizVisitorLog {

Expand Down

6 comments on commit 6148bb1

@diosmosis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke the styling for the themes admin page:

Before: https://raw.github.com/piwik/piwik-ui-tests/master/expected-ui-screenshots/UIIntegrationTest_admin_themes.png
After: http://builds-artifacts.piwik.org/ui-tests.master/1607.1/processed-ui-screenshots/UIIntegrationTest_admin_themes.png

Was this intentional or a regression?

@diosmosis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question for custom alerts tables:

Before: https://raw.github.com/piwik/piwik-ui-tests/master/expected-ui-screenshots/UIIntegrationTest_customalerts_list.png
After: http://builds-artifacts.piwik.org/ui-tests.master/1607.1/processed-ui-screenshots/UIIntegrationTest_customalerts_list.png

@timo-bes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say custom alerts intentional, themes not. I haven't used the UI tests before. I'll fix it as soon as I can.

@timo-bes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that active plugins were not highlighted. This is fixed in db95706
However, the UI tests will still fail because it looks different than before. First of all, who can determine what is correct? Imho, highlighting active plugins in dark is better because the default color is white. For the same reason, the alerts table should be white. So this is expected in my opinion.
Can I update the expected screenshots? How?

@timo-bes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better if we continue the discussion here: http://dev.piwik.org/trac/ticket/4536

@mattab
Copy link
Member

@mattab mattab commented on 6148bb1 Feb 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

highlighting active plugins in dark is better because the default color is white.
Active plugins are in white, because it looks better (they are more active plugins than inactive, and more white looks better).

Agreed that custom alerts and other entity tables should be white.

Regarding how to fix UI tests, good question! I just wrote the workflow: https://github.com/piwik/piwik/blob/master/tests/README.screenshots.md#using-screenshots-tests

let me know if that's clear, 👍 for tackling these UI bugs!

Please sign in to comment.