improved detection for some sharp devices

matomo-org · Jan 23, 2014 · 6c60740 · 6c60740
1 parent 0ddd84d
commit 6c60740
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/plugins/DevicesDetection/UserAgentParserEnhanced/regexes/mobiles.yml b/plugins/DevicesDetection/UserAgentParserEnhanced/regexes/mobiles.yml
@@ -872,7 +872,7 @@ Spice:
 
 # Sharp
 Sharp:
-  regex: 'SHARP|SBM'
+  regex: 'SHARP|SBM|SH-[0-9]+[a-z]? Build'
   device: 'smartphone'
   models: 
     - regex: 'SHARP-AQUOS'
@@ -882,6 +882,8 @@ Sharp:
       model: '$1'
     - regex: '(?:SHARP|SBM)([a-z0-9]+)'
       model: '$1'
+    - regex: '(SH-[0-9]+[a-z]?) Build'
+      model: '$1'
 
 # Softbank
 Softbank:

diff --git a/tests/PHPUnit/Fixtures/userAgentParserEnhancedFixtures.yml b/tests/PHPUnit/Fixtures/userAgentParserEnhancedFixtures.yml
@@ -4073,9 +4073,9 @@
     short_name: AN
     version:
   device:
-    type:
-    brand:
-    model:
+    type: smartphone
+    brand: SH
+    model: SH-07D
   os_family: Android
   browser_family: Android Browser
 - 
@@ -11774,3 +11774,19 @@
     model: Nova8
   os_family: Android
   browser_family: Android Browser
+-
+  user_agent: Mozilla/5.0 (Linux; Android 4.0.4; SH-10D Build/S4040) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.90 Mobile Safari/537.36
+  os:
+    name: Android
+    short_name: AND
+    version: 4.0
+  browser:
+    name: Chrome Mobile
+    short_name: CM
+    version: 27.0
+  device:
+    type: smartphone
+    brand: SH
+    model: SH-10D
+  os_family: Android
+  browser_family: Chrome