refs #4338 prevent javascript error on FireFox

matomo-org · Nov 27, 2013 · bc5ddf9 · bc5ddf9
1 parent e71d5d6
commit bc5ddf9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/plugins/CorePluginsAdmin/templates/macros.twig b/plugins/CorePluginsAdmin/templates/macros.twig
@@ -15,13 +15,13 @@
             {% for name,plugin in pluginsHavingUpdate %}
                 <tr {% if plugin.isActivated %}class="highlighted"{% endif %}>
                     <td class="name">
-                        <a href="javascript:false;" data-pluginName="{{ plugin.name|e('html_attr') }}">
+                        <a href="javascript:void(0);" data-pluginName="{{ plugin.name|e('html_attr') }}">
                             {{ plugin.name }}
                         </a>
                     </td>
                     <td class="vers">
                         {% if plugin.repositoryChangelogUrl %}
-                            <a href="javascript:false;" title="{{ 'CorePluginsAdmin_Changelog'|translate }}" data-activePluginTab="changelog" data-pluginName="{{ plugin.name|e('html_attr') }}">{{ plugin.currentVersion }} => {{ plugin.latestVersion }}</a>
+                            <a href="javascript:void(0);" title="{{ 'CorePluginsAdmin_Changelog'|translate }}" data-activePluginTab="changelog" data-pluginName="{{ plugin.name|e('html_attr') }}">{{ plugin.currentVersion }} => {{ plugin.latestVersion }}</a>
                         {% else %}
                             {{ plugin.currentVersion }} => {{ plugin.latestVersion }}
                         {% endif %}
@@ -115,7 +115,7 @@
                 <tr {% if plugin.activated %}class="highlighted"{% endif %} data-filter-status="{% if plugin.activated %}active{% else %}inactive{% endif %}" data-filter-origin="{% if plugin.isCorePlugin %}core{% else %}noncore{% endif %}">
                     <td class="name">
                         {% if not plugin.isCorePlugin and name in marketplacePluginNames -%}
-                            <a href="javascript:false;"
+                            <a href="javascript:void(0);"
                                data-pluginName="{{ name|e('html_attr') }}"
                                >{{ name }}</a>
                         {%- else %}

diff --git a/plugins/CorePluginsAdmin/templates/pluginOverview.twig b/plugins/CorePluginsAdmin/templates/pluginOverview.twig
@@ -15,11 +15,11 @@
 
 
 <h3 class="header" title="{{ 'General_MoreDetails'|translate }}">
-    <a href="javascript:false;" class="more">{{ plugin.name }}</a>
+    <a href="javascript:void(0);" class="more">{{ plugin.name }}</a>
 </h3>
 <p class="description">{{ plugin.description }}
     <br />
-    <a href="javascript:false;" title="{{ 'General_MoreDetails'|translate }}" class="more">&gt;&gt; {{ 'General_MoreLowerCase'|translate }}</a>
+    <a href="javascript:void(0);" title="{{ 'General_MoreDetails'|translate }}" class="more">&gt;&gt; {{ 'General_MoreLowerCase'|translate }}</a>
 </p>
 {% if plugin.canBeUpdated %}
     <p class="updateAvailableNotice" data-activePluginTab="changelog">{{ 'CorePluginsAdmin_PluginUpdateAvailable'|translate(plugin.currentVersion, plugin.latestVersion) }}</p>

diff --git a/plugins/CorePluginsAdmin/templates/themeOverview.twig b/plugins/CorePluginsAdmin/templates/themeOverview.twig
@@ -14,7 +14,7 @@
 {% endif %}
 
 <h3 class="header" title="{{ 'General_MoreDetails'|translate }}">
-    <a href="javascript:false;" class="more">{{ plugin.name }}</a>
+    <a href="javascript:void(0);" class="more">{{ plugin.name }}</a>
 </h3>
 
 <p class="description">{% if plugin.featured %}{{ plugins.featuredIcon('right') }}{% endif %}{{ plugin.description }}</p>
@@ -23,5 +23,5 @@
     <p class="updateAvailableNotice">{{ 'CorePluginsAdmin_ThemeUpdateAvailable'|translate(plugin.currentVersion, plugin.latestVersion) }}</p>
 {% endif %}
 
-<a href="javascript:false;" class="more"><img  title="{{ 'General_MoreDetails'|translate }}"
+<a href="javascript:void(0);" class="more"><img  title="{{ 'General_MoreDetails'|translate }}"
             class="preview" src="{{ plugin.screenshots|first }}?w=250&h=250"/></a>