Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Live does not always show recent visitors based on timezone #2145

Closed
robocoder opened this Issue · 7 comments

3 participants

Anthon Pang Anonymous Piwik user Matthieu Aubry
Anthon Pang
Collaborator

These issues are intertwined. I think we should refactor the Live plugin and add some much needed unit tests.

Timezone:

Export limits:

Anonymous Piwik user

Confirmed, regression of #1458 again

Anthon Pang
Collaborator

IIRC this was to fix a problem when the period != 'day'.

Matthieu Aubry
Owner

See proposed patch in: http://forum.piwik.org/read.php?2,72889,page=1#msg-72911

/piwik/plugins/Live/API.php you will find on about line 240:
- $processedDate = Piwik_Date::factory($date, $currentTimezone);// if not commented, the Period below fails ->setTimezone($currentTimezone);
+ $processedDate = Piwik_Date::factory($date)->setTimezone($currentTimezone);
Matthieu Aubry
Owner

(In [4188]) Refs #572

  • Adding Date Range calendar UI, with "Apply Date Range" button. Possibility to edit the INPUT fields directly rather than clicking in the calendar. Testing that dates are valid (from < to, valid string).
  • Updating calendar to show Loading.. on click (hopefully it makes it less confusing)
  • Fixing few bugs when period=range
  • All reports should load correctly when period=range, including sparklines, graphs & standard tables
  • Refs #2145 renaming parameter to $filter_limit which seems to work OK - it's not even a hack isn't it? :) TODO:
  • refactor period_select.tpl JS in helper,
  • Metadata compatibility with period=range (at least the World map doesn't work for now)
  • previous TODO still valid

Testing is welcome, please report any bug you find!

Anonymous Piwik user

This change resolved my issue with incorrectly processed time zones.

Matthieu Aubry
Owner

(In [4316]) Fixes #2145 as far as I can see, it should be fixed, but I've been wrong all previous times so testing is very much welcome! thx

Refs #1966 Improving visitor log performance by rewriting the query

Anthon Pang robocoder added this to the Piwik 1.3 milestone
Matthieu Aubry mattab was assigned by robocoder
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.