Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Snort: false positive on piwik.js #2203

Closed
robocoder opened this Issue · 2 comments

1 participant

@robocoder

Snort generates a false positive on this line in piwik.js:

        escapable = new RegExp('[\\\\\\"\x00-\x1f\x7f-\x9f\u00ad\u0600-\u0604\u070f\u17b4\u17b5\u200c-\u200f\u2028-\u202f\u2060-\u206f\ufeff\ufff0-\uffff]', 'g'),

The Snort rule doesn't check for a closing ] (which was the Mozilla bug that this rule was supposed to detect).

@robocoder

(In [4127]) fixes #2203

@robocoder

(In [4128]) refs #2203 - add unit test for regressions

@robocoder robocoder added this to the Piwik 1.3 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.