Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Morpheus theme makes tables in security settings partly unreadable #4682

Closed
null-minus-null opened this Issue · 19 comments

3 participants

@null-minus-null

In Morpheus theme every second row of the tables in the security info page has white backgroud instead of green or yellow one.
This makes it impossible to read text, which should have green background(due to the white font color).

The problematic css is

.dataTable tr:nth-child(2n) td {
    background-color: rgb(255, 255, 255) !important;
}

which overrides the inline css.

See attached screenshot!

@mattab
Owner

this looks fixed in latest SecurityInfo plugin and 2.1-rc1 please reopen if not!

@null-minus-null

In my installation SecurityInfo-tables look even worse wit 2.1RC1, because all colors are gone now.

See the new screenshot.

@hpvd

same here.
Put an other screenshot as attachment which highlights the problem a bit more...

@mattab
Owner

I'm using 2.1 RC1 and the latest securityInfo plugion from the marketplace and cannot replicate this issue. I'm confused that you are getting this with latest RC...

@hpvd

just installed again latest master piwik from github:
everything look still the same with

  • firefox 28 and
  • opera 12.16

no new updates for plugins are shown/everything is up to date

PHP is v5.3.27

@mattab
Owner

In ca55552: Refs #4682 Adding screenshot test for security info page, to see if we can replicate the bug on Travis

@mattab
Owner

as you can see here: http://builds-artifacts.piwik.org/ui-tests.master/1653.1/processed-ui-screenshots/UIIntegrationTest_admin_security_info.png

the screenshot looks ok even on travis.

Can you try delete the tmp/ folder of your Piwik?

@mattab
Owner

I released a new version of the Security Info plugin which I think will fix the issue! http://plugins.piwik.org/SecurityInfo

@null-minus-null

Updated Piwik and the Plugin: Now everything works fine.

@hpvd

nearly fine ;-)
the lines which are back again now have a different green colour...

please see attachment

@mattab
Owner

Screenshot looks ok, what's the problem on it?

@hpvd

hmm
to different green font colours are used:

#9B7A44
#468847

=> is it a feature?

see new screenshot...

@null-minus-null

468847 is green("this setting is OK") -> previously green background

9B7A44 is red/brown("this setting is bad") -> previously yellow background

But I think the second color should be changed somehow, at the moment it looks more brown than red (which would fit better for the purpose of a probable security issue).

btw should there really be written

<em>disabled</em>

in allow_url_fopen ;)

@mattab
Owner

Fixed in SecurityInfo 1.0.4 piwik/plugin-SecurityInfo@ccd5766

@null-minus-null null-minus-null added this to the 2.1 - Piwik 2.1 milestone
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@mattab mattab Refs #4682 Adding screenshot test for security info page, to see if w…
…e can replicate the bug on Travis
ca55552
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.