Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognition for IE11, Opera 15+ and Maxthon, made Win 8.1 for version 1.X #164

Merged
merged 4 commits into from Dec 9, 2013
Merged

Recognition for IE11, Opera 15+ and Maxthon, made Win 8.1 for version 1.X #164

merged 4 commits into from Dec 9, 2013

Conversation

mpopp75
Copy link

@mpopp75 mpopp75 commented Dec 9, 2013

If you reject pull request #161 for the master branch (i.e. Piwik 2.0+), you may still want to consider these updates for Piwik 1.x (1.13 going forward).

Piwik 1.12 currently doesn't recognize IE11, Windows 8.1 and Maxthon. Opera versions 15+ are wrongly identified as Google Chrome.

Renamed old test script to
UserAgentParser.test.oldbrowsers.php

Conflicts:
	libs/UserAgentParser/UserAgentParser.test.php
With abbreviation W81 (instead of WI8)

Conflicts:
	libs/UserAgentParser/UserAgentParser.php
Add one more entry for Windows 8.1
Add icons for Windows 8.1 and Maxthon
Fix unit test failures
@mattab
Copy link
Member

mattab commented Dec 9, 2013

I trust you have tested well the code as I haven't.

Thanks for the Pull request!

@mattab mattab closed this Dec 9, 2013
@mattab mattab reopened this Dec 9, 2013
mattab pushed a commit that referenced this pull request Dec 9, 2013
Recognition for IE11, Opera 15+ and Maxthon, made Win 8.1 for version 1.X
@mattab mattab merged commit f4aabfb into matomo-org:1.X Dec 9, 2013
@mpopp75 mpopp75 deleted the useragents-1.x branch December 9, 2013 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants