Optimize DatabaseTestCase so travis build will be faster #6331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -525,11 +525,19 @@ protected static function getDbTablesWithData() | |||
| */ | |||
| protected static function restoreDbTables($tables) | |||
| { | |||
| $tablesPrefix = Config::getInstance()->database_tests['tables_prefix']; | |||
There was a problem hiding this comment.
This logic should be moved to truncateAllTables() since this function was only meant to be used here and is not used in other places
diosmosis
force-pushed
the
db_test_case_optimize
branch
from
790daf2
to
e0badcc
Compare
added 7 commits
October 1, 2014 19:10
…nd tweaks to DatabaseTestCase tests.
diosmosis
force-pushed
the
db_test_case_optimize
branch
from
fecc8c4
to
d4e8f01
Compare
diosmosis
pushed a commit
that referenced
this pull request
Oct 2, 2014
Optimize DatabaseTestCase by creating DB and tables only once (like IntegrationTestCase) so travis build will be faster.
mattab
added
the
c: Tests & QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified DatabaseTestCase to setup the database once per test case (in setUpBeforeClass) as is done with IntegrationTestCase. This decreases the build time for Integration tests for about 25 mins to 15mins.
@mattab Please review.