-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved Intl data translations to a new plugin #8017
Conversation
98cd4f8
to
bd85069
Compare
bd85069
to
cc57e57
Compare
Moved Intl data translations to a new plugin
LGTM. Especially nice that it can be improved later and add more strings from i18n project, to save time to our translators, and save them from translating incorrectly those important date/time strings. |
@sgiehl I noticed a small regression, in French for example, translation for "Today" becomes "aujourd'hui". Expected to get "Aujourd'hui" with ucfirst/ capital letter. Maybe the Intl data has the version with capital letter first? or maybe we can use |
No. There's no data with other cases. In Germany the first letters are uppercase. Not sure why they aren't for French. I could apply a ucfirst when importing those data... |
I decided to move the Intl-data translations away from core into a new plugin.
That makes it much easier to handle the translations and doesn't make it necessary to change to much in the translation logic.
I've also reverted some of the changes made before, as they weren't needed anymore.
The Intl-Plugin now contains the translations for:
I maybe add some more stuff as cldr also contains translations for date fields like
tomorrow
,yesterday
,day
,week
,month
,year
and so onNote: Some language names have changed, but I think we should use those provided by CLDR, as they might be more correct than those we used.