Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix there is only 1px paddingRight for entity tables #8183

Merged
merged 4 commits into from
Jun 24, 2015
Merged

Fix there is only 1px paddingRight for entity tables #8183

merged 4 commits into from
Jun 24, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 23, 2015

Fixes especially the plugin list where deactivate was completely on the right border http://builds-artifacts.piwik.org/ui-tests.master/13651.7/UIIntegrationTest_admin_plugins

@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Jun 23, 2015
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jun 23, 2015
@tsteur tsteur added this to the 2.14.0 milestone Jun 23, 2015
@tsteur
Copy link
Member Author

tsteur commented Jun 24, 2015

See eg http://builds-artifacts.piwik.org/ui-tests.fix_entity-table_no_padding_right/13683.7/UIIntegrationTest_admin_manage_users

http://builds-artifacts.piwik.org/ui-tests.fix_entity-table_no_padding_right/13683.7/UIIntegrationTest_admin_plugins

http://builds-artifacts.piwik.org/ui-tests.fix_entity-table_no_padding_right/13683.7/UIIntegrationTest_admin_themes

http://builds-artifacts.piwik.org/ui-tests.fix_entity-table_no_padding_right/13683.7/UIIntegrationTest_email_reports

http://builds-artifacts.piwik.org/ui-tests.fix_entity-table_no_padding_right/13683.7/UIIntegrationTest_goals_manage

It also includes a version of a flatter reporting menu
http://builds-artifacts.piwik.org/ui-tests.fix_entity-table_no_padding_right/13683.7/Menus_mainmenu_loaded

mattab pushed a commit that referenced this pull request Jun 24, 2015
Merge pull request #8183 from piwik/fix_entity-table_no_padding_right
286096a 
Fix there is only 1px paddingRight for entity tables
@mattab mattab merged commit 286096a into master Jun 24, 2015
@mattab mattab deleted the fix_entity-table_no_padding_right branch June 24, 2015 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tsteur @mattab