-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix triggers select in Add Goal form #8267
Conversation
I still have to click on the select for the changes to be applied, even after I changed the value. Just had a quick look and it might be enough to listen to the That might be the only change needed but not sure re side effects. If that works, we could undo the other changes probably. |
Changed |
Which browser are you using? It did not work for me on Chrome 43 with MacOSX. @mattab the select box is now moved to the right see: http://i.imgur.com/gKzOzt0.gif What's your thought on that? |
I use Chrome 43, Firefox 34 and Opera 12 on Win8.1x64. Regarding new select box position, I moved it to the right side because I thought it's HTML bug that it was located in left side. Also I think it will be better if we set But anyway, it's up to you, guys, to chose the best solution. I'm not a designer :) |
Fix triggers select in Add Goal form
we're also not designers, but we do our best to build UI that look good and are usable. it's very important part of building a successful and amazing product. Could you add some space below this SELECT box as you can see it's too close to the radio boxes below |
@mattab What browser do you use? In Chrome 43 and Firefox 34 there is a space already |
I like it much better, maybe you can issue another PR? |
@barbushin I can see this behavior on both latest Chromium and Firefox on ubuntu |
@mattab It's very strange because I can't reproduce it. There is |
Closes #8244