Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(front): Select object by clicking them #105

Merged
merged 14 commits into from
Feb 7, 2024

Conversation

timothee-LJN
Copy link
Contributor

issues

Fixes #83 and #85

description

  • refacto addBox to create a dedicated <Rectangle /> component to use Konva/svelte component
  • refacto PolygonGroup to use directly the created mask and reduce complexity
  • select item in inspector clicking on the object card colored dot or double clicking on the shape (bbox or mask)
  • clicking everywhere else on the image unselect the object
  • clicking again on the object card colored unselect the object
  • when selected, an object strokeWidth get bigger and its card is slightly highlighted
image

@timothee-LJN timothee-LJN added enhancement New feature or request scope: front Related to Pixano frontend labels Feb 7, 2024
@timothee-LJN timothee-LJN self-assigned this Feb 7, 2024
@cpvannier cpvannier linked an issue Feb 7, 2024 that may be closed by this pull request
@cpvannier cpvannier added this to the Pixano 0.5.0 milestone Feb 7, 2024
cpvannier

This comment was marked as resolved.

@timothee-LJN timothee-LJN force-pushed the feat/select-object-by-clicking-them branch from 2664d41 to 2d70474 Compare February 7, 2024 15:27
@timothee-LJN

This comment was marked as resolved.

@timothee-LJN timothee-LJN merged commit 341efaf into develop Feb 7, 2024
5 checks passed
cpvannier pushed a commit that referenced this pull request Feb 15, 2024
* refactor(front): Use Rectangle shape from KonvaSvelte library

* Merge remote-tracking branch 'origin/develop' into feat/select-object-by-clicking-them

* fix(front): Hide pre annotation item before they are annotated

* style: Refactor bounding box API and remove unused code

* feat: Show object card icon when editing mode is on

* feat: Highlight object in inspector when double clicking on shape

* feat(front): Remove object highlighting when clicking outside or on dot again

* fix(front): Do not bind values in pre annotation to avoid unnecessary rerender

* feat(front): Unhighlight object when hiding object

* feat(front): Lighten mask highlight

* fix(front): Improve click outside highlighted shape

* refactor(front): Use mask in Polygon Group

* fix(front): Prevent saving when shape is highlighted
@cpvannier cpvannier deleted the feat/select-object-by-clicking-them branch February 20, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scope: front Related to Pixano frontend
Projects
None yet
3 participants