-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(front): Select object by clicking them #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-by-clicking-them
2664d41
to
2d70474
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cpvannier
approved these changes
Feb 7, 2024
BertrandRenault
approved these changes
Feb 7, 2024
cpvannier
pushed a commit
that referenced
this pull request
Feb 15, 2024
* refactor(front): Use Rectangle shape from KonvaSvelte library * Merge remote-tracking branch 'origin/develop' into feat/select-object-by-clicking-them * fix(front): Hide pre annotation item before they are annotated * style: Refactor bounding box API and remove unused code * feat: Show object card icon when editing mode is on * feat: Highlight object in inspector when double clicking on shape * feat(front): Remove object highlighting when clicking outside or on dot again * fix(front): Do not bind values in pre annotation to avoid unnecessary rerender * feat(front): Unhighlight object when hiding object * feat(front): Lighten mask highlight * fix(front): Improve click outside highlighted shape * refactor(front): Use mask in Polygon Group * fix(front): Prevent saving when shape is highlighted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues
Fixes #83 and #85
description
<Rectangle />
component to useKonva/svelte
component