fix(front): Fix buttons in Toolbar #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use name attribute as tooltip, fix descriptions - Fix typo polygoneTool > polygonTool
- Use IconButton for smart tool list button, which allows using the same tooltip as other buttons - Redefine double click action as it is not implemented in IconButton - Show the model selection modal everytime the smart tool list is opened instead of on double click - Close the smart tool list when selecting a non smart tool to show the model selection modal when selecting the smart tool list again
cpvannier
added
enhancement
cpvannier
changed the title
BertrandRenault
approved these changes
Feb 8, 2024
Revert closing the smart list on tool change to prompt for model selection when re-opening the smart list. Closing and re-opening the smart list manually to change model is enough.
timothee-LJN
approved these changes
Feb 8, 2024
cpvannier
added a commit
that referenced
this pull request
Feb 15, 2024
* fix(front): Fix tool buttons tooltips - Use name attribute as tooltip, fix descriptions - Fix typo polygoneTool > polygonTool * fix(front): Redefine smart tool list button with IconButton - Use IconButton for smart tool list button, which allows using the same tooltip as other buttons - Redefine double click action as it is not implemented in IconButton - Show the model selection modal everytime the smart tool list is opened instead of on double click - Close the smart tool list when selecting a non smart tool to show the model selection modal when selecting the smart tool list again * fix(front): Revert closing the smart list on tool change Revert closing the smart list on tool change to prompt for model selection when re-opening the smart list. Closing and re-opening the smart list manually to change model is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #114
Description
SelectionTool.nameastooltipContentfor all buttonspolygoneTool>polygonTooltooltipContentlike the other buttonson:dblclickis not implemented in IconButton. Show the model selection modal every time the smart tool list is opened instead. Closing and re-opening the smart tool list works similarly to double clicking.