-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Connect new API to frontend #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Update frontend for interactive segmentation and semantic search
Return None if embeddings of given model_id not found
Cannot return search query with get
Remove unused import Add missing await
Look for model name inside model path instead of the other way around Make both model name and model path lowercase to prevent case issues
Remove exception for missing pixano-inference module Install pixano-inference in unit tests GitHub action
When loading item pages, disable loading media features like image height and width that require opening the file metadata Item pages now load faster
When displaying item pages in Explorer, use thumbnails for images instead of opening them
Please run `pnpm i` to install nanoid For more info on shortid deprecation: https://www.npmjs.com/package/shortid
- typescript-eslint/no-base-to-string fixed with new API, that allows getting item ID without looking in features - typescript-eslint/no-unsafe-call fixed with the following changes: - Refactored until() functions - Refactored tools (specifcally Point Selection) - Commented unused code in VideoCell
Fix change from 9545f65 Need to include Konva.Group and Konva.Shape to delete bboxes and masks
- typescript-eslint/no-unsafe-assignment fixed with: - Add type to embeddings in Canvas2D - Add type to handleWheelOnImage in Canvas2D - Add types when loading JSON data in api.ts and npy.ts - typescript-eslint/no-unsafe-member-access mostly fixed with: - Add type to handleClickOnImage in Canvas2D - Add type to handleKeyPress in CategoryToolbar - But can't add type to event.detail.evt in Canvas2D - no-undef fixed by adding browser to env
Toggling label visibility sometimes does not work for label sources other than Ground Truth. Hard to pinpoint the source of the issue.
Hide "Show remaining items only" toggle if dataset has no active learning related columns (check for "round")
BertrandRenault
approved these changes
Dec 5, 2023
timothee-LJN
approved these changes
Dec 6, 2023
cpvannier
added
scope: api
Related to Pixano API
enhancement
New feature or request
labels
Dec 6, 2023
jrabary
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace old API by updated API and connect to frontend
Fixes #14
Changes
Added
Changed
Fixed