fix(front): Fix buttons in DatasetHeader #120
Conversation
- Go back to home page if on dataset page - Go back to dataset page if on item page - Pixano logo already goes back to home page regardless of current page
cpvannier
added
enhancement
| @@ -105,22 +105,25 @@ | |||
| <button on:click={() => navigateTo("/")} class="h-10 w-10"> | |||
| <img src={pixanoLogo} alt="Logo Pixano" class="w-8 h-8 mx-2" /> | |||
| </button> | |||
| <IconButton on:click={() => navigateTo("/")}> | |||
| <IconButton | |||
| on:click={() => navigateTo(currentItemId ? `/${datasetName}/dataset` : "/")} | |||
There was a problem hiding this comment.
maybe we could just implement a "go back" feature for this button ? https://stackoverflow.com/a/71585077/22966091
I'm also wondering if this button is really useful since there are always a way to go back to dataset (with the dedicated button) or home (with the logo).
There was a problem hiding this comment.
I guess an actual "Go back" button is not really necessary since we can use the browser's own "Go back" and "Go forward" buttons now.
I made this change because the button is included in the Sketch template, but otherwise I would have considered deleting it, since like you said there is the logo and the dedicated button. Then again having that button is maybe more intuitive for users. This probably deserves a discussion with Janro.
* fix(front): Add tooltips for navigation buttons * fix(front): Use back button to go to parent page - Go back to home page if on dataset page - Go back to dataset page if on item page - Pixano logo already goes back to home page regardless of current page
Issue
Fixes #119
Description