fix(front): Fix issues with loading segmentation models #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If loadEmbeddingsApi return an empty embeddings object without error, the noEmbeddings modal is not triggered
Without updating currentModalOpen in modelsStore, the noEmbeddings modal would wrongly trigger again after switching from a model with no embeddings to a model with embeddings
When clicking too quickly after selecting an interactive model, it is possible to trigger the viewEmbeddingModal because the embeddings have not finished loading yet.
cpvannier
added
enhancement
BertrandRenault
approved these changes
Feb 8, 2024
timothee-LJN
approved these changes
Feb 9, 2024
cpvannier
added a commit
that referenced
this pull request
Feb 15, 2024
* fix(front): Throw error if empty embeddings to trigger modal If loadEmbeddingsApi return an empty embeddings object without error, the noEmbeddings modal is not triggered * fix(front): Fix updating current opened modal Without updating currentModalOpen in modelsStore, the noEmbeddings modal would wrongly trigger again after switching from a model with no embeddings to a model with embeddings * fix(front): Add warning that embeddings may have not finished loading When clicking too quickly after selecting an interactive model, it is possible to trigger the viewEmbeddingModal because the embeddings have not finished loading yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #123
Description
modelsApiif empty embeddings received to trigger the "No embeddings found for model" modalcurrentModalOpenvariable that would trigger the "No embeddings found for model" modal even after switching model