Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(front): Ask for confirmation before leaving item page #126

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

cpvannier
Copy link
Member

@cpvannier cpvannier commented Feb 8, 2024

Issue

Fixes #125

Description

When using any buttons in the DatasetHeader, ask for confirmation if they are any unsaved changes.
Previously, only the Next item and Previous item buttons would ask for confirmation.

@cpvannier cpvannier added enhancement New feature or request scope: front Related to Pixano frontend labels Feb 8, 2024
@cpvannier cpvannier added this to the Pixano 0.5.0 milestone Feb 8, 2024
@cpvannier cpvannier self-assigned this Feb 8, 2024
@cpvannier cpvannier merged commit 90bcd66 into develop Feb 9, 2024
5 checks passed
cpvannier added a commit that referenced this pull request Feb 15, 2024
* feat(front): Ask for confirmation before leaving item page

* fix(front): Add missing await keyword

* fix(front): Fix typo
@cpvannier cpvannier deleted the feat/confirm_leave_item branch February 20, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scope: front Related to Pixano frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask confirmation before leaving item page
3 participants