feat: Add features auto-completion #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BertrandRenault
added
enhancement
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timothee-LJN
reviewed
Feb 9, 2024
ui/components/imageWorkspace/src/components/Features/FeatureFormInputs.svelte
Outdated
Show resolved
Hide resolved
ui/components/imageWorkspace/src/components/Features/FeatureFormInputs.svelte
Outdated
Show resolved
Hide resolved
ui/components/imageWorkspace/src/components/Features/TextInputFeature.svelte
Outdated
Show resolved
Hide resolved
ui/components/imageWorkspace/src/components/SaveShape/SaveShapeForm.svelte
Outdated
Show resolved
Hide resolved
ui/components/imageWorkspace/src/components/Features/TextInputFeature.svelte
Outdated
Show resolved
Hide resolved
ui/components/imageWorkspace/src/components/Features/TextInputFeature.svelte
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
True, this deserves its separate issue: pixano/pixano-project-manager#46 Also, regarding storing |
cpvannier
approved these changes
Feb 13, 2024
ui/components/imageWorkspace/src/components/Features/FeatureFormInputs.svelte
Outdated
Show resolved
Hide resolved
ui/components/imageWorkspace/src/components/Features/TextInputFeature.svelte
Outdated
Show resolved
Hide resolved
timothee-LJN
approved these changes
Feb 15, 2024
cpvannier
pushed a commit
that referenced
this pull request
Feb 15, 2024
* auto-completion * fix(front): correctly manage types from back * add scene auto-complete * fix adding duplicate, add scene new values * typos + ensure different htmlElem id * remove category, refactor code, simplify * put categories back * renaming * use datasetsStore instead of dedicated store * (back) type FeaturesValue instead of primitive type * feat(front): Display listItems in a command component * feat: Save before refacto * feat: Save scene values * feat(front): Add new component to FeatureForm * feat(front): Add feature for scene features * feat(front): Save autocomplete on dropdown select * fix(front): Allow empty feature list in autocomplete * fix(front): Do not close autocomplete list if its hovered * feat(front): Sort list item alphabetically * refactor(front): Rename Features components * fix(front): move featuresValues store from datasets to itemMetas * refactor(front): Rename features in meta object --------- Co-authored-by: Timothee Reynaud <timothee.r@lajavaness.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #76
Notes:
for Scene features, as there is often/always a default value, the auto-completion only show the current option, others options are shown if we delete current value
available values are read from tables in back, not from db.json. This could be done in a future PR, if necessary
(back) merge with "categories" -> related to previous, if we choose to save available values in db.json, we will refactor "categories" to be more generic