Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(back): Fix getting category name in COCO Importer #13

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

magwyz
Copy link

@magwyz magwyz commented Dec 1, 2023

The category_name field does not always exist in an annotation object.

@magwyz
Copy link
Author

magwyz commented Dec 1, 2023

I got this issue from a dataset annotated with CVAT.

@cpvannier
Copy link
Member

cpvannier commented Dec 4, 2023

Thank you for the suggestion!

I left a few notes on what I would change, just a minor edit for readability.

Also, it would be great if you could format your code with Black so that it passes our lint test. You can install the VS Code extension and set it to format files automatically on save, or if you use another editor, you can run it directly with the PyPI package.

And finally, this update should be mentioned in the CHANGELOG.md file under Unreleased - Fixed:

- Fix COCO Importer to get the category name from the "categories" field as it does not always exist in the "annotations" field

Thanks again!

@cpvannier cpvannier changed the title coco importer: get the category name of an annotation from its category object fix(back): Fix getting category name in COCO Importer Dec 4, 2023
@cpvannier cpvannier added scope: back Related to Pixano backend bug: minor Minor issues, minimal user impact labels Dec 6, 2023
@cpvannier cpvannier self-assigned this Dec 6, 2023
@magwyz magwyz force-pushed the develop branch 2 times, most recently from 1c8ced5 to 8a29fa1 Compare December 13, 2023 15:51
…ry object

The category_name field does not always exist in an annotation object.
@jrabary jrabary merged commit 4dbdf64 into pixano:develop Dec 14, 2023
5 checks passed
@cpvannier cpvannier added this to the Pixano 0.5.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: minor Minor issues, minimal user impact scope: back Related to Pixano backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants