Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): Refetch saved item #131

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

timothee-LJN
Copy link
Contributor

@timothee-LJN timothee-LJN commented Feb 9, 2024

issue

fixes #89 (part 2)

description

In order to display the bbox around a created mask, the current item is fetched (GET) right after its saved (POST) to get fresh data. Reconciliation had to be done (to keep UI state as it was before saving)

@timothee-LJN timothee-LJN added bug: minor Minor issues, minimal user impact scope: front Related to Pixano frontend labels Feb 9, 2024
@timothee-LJN timothee-LJN self-assigned this Feb 9, 2024
@timothee-LJN timothee-LJN marked this pull request as draft February 9, 2024 16:16
@timothee-LJN timothee-LJN changed the title Feat/fetch item after saved fix(front): Refetch saved item Feb 12, 2024
@timothee-LJN timothee-LJN modified the milestone: Pixano 0.5.0 Feb 12, 2024
@cpvannier cpvannier added this to the Pixano 0.5.0 milestone Feb 12, 2024
@timothee-LJN timothee-LJN marked this pull request as ready for review February 12, 2024 13:52
@timothee-LJN timothee-LJN merged commit f178edb into develop Feb 12, 2024
5 checks passed
cpvannier pushed a commit that referenced this pull request Feb 15, 2024
* feat(front): Fetch item after saving

* feat(front): Reconciliate new fetched objects and currently displayed items

* refactor(front): Refactor object mapping in ImageWorkspace.svelte
@cpvannier cpvannier deleted the feat/fetch-item-after-saved branch February 27, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: minor Minor issues, minimal user impact scope: front Related to Pixano frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create bbox from mask and display it after saving
3 participants