chore: Freaze lockfile in CI #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrabary Is there any reason why it like so? |
|
We can remove it from gitignore. |
BertrandRenault
approved these changes
Feb 14, 2024
cpvannier
approved these changes
Feb 15, 2024
cpvannier
pushed a commit
that referenced
this pull request
Feb 15, 2024
* chore: Freaze lockfile in CI * chore: Remove *lock.yaml from gitignore * chore: Add pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
fixes #97
description
Instead of locking manually package version, I've added a flag
--frozen-lockfileto GH actions.According the docs this should have been the case since the command was run in CI already. So maybe there is something we did wrong or
CI=TRUEwas not explicit enough?--frozen-lockfileflag is equivalent tonpm ci: https://docs.npmjs.com/cli/v10/commands/npm-ci