-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(back): correct AWS env var name #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to keep consistency and follow the conventional commit pattern you could rename the PR
chore: Correct AWS env var names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request name should be updated to follow the Conventional Commits guidelines.
Also, something seems wrong with the name of issue #137 reporting the error and the steps to reproduce:
This looks like a problem caused by #93 not updating the serve.py
file, causing a conflict between the App
args and the Settings
args. But #93 is not included in v0.5.0b3
, so this error does not appear when running pip install pixano==0.5.0b3
, only when installing Pixano from the develop branch (locally or from GitHub).
You right, it was not from pixano0.5.0b3 but local develop version. Issue has been edited accordingly |
close #137