Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(back): correct AWS env var name #138

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

BertrandRenault
Copy link
Contributor

close #137

@BertrandRenault BertrandRenault added bug: minor Minor issues, minimal user impact scope: back Related to Pixano backend labels Feb 12, 2024
@BertrandRenault BertrandRenault added this to the Pixano 0.5.0 milestone Feb 12, 2024
@BertrandRenault BertrandRenault self-assigned this Feb 12, 2024
@BertrandRenault BertrandRenault marked this pull request as ready for review February 12, 2024 14:52
Copy link
Contributor

@timothee-LJN timothee-LJN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to keep consistency and follow the conventional commit pattern you could rename the PR
chore: Correct AWS env var names

Copy link
Member

@cpvannier cpvannier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request name should be updated to follow the Conventional Commits guidelines.

Also, something seems wrong with the name of issue #137 reporting the error and the steps to reproduce:
This looks like a problem caused by #93 not updating the serve.py file, causing a conflict between the App args and the Settings args. But #93 is not included in v0.5.0b3, so this error does not appear when running pip install pixano==0.5.0b3, only when installing Pixano from the develop branch (locally or from GitHub).

@BertrandRenault BertrandRenault changed the title correct env var name fix(back): correct env var name Feb 13, 2024
@BertrandRenault BertrandRenault changed the title fix(back): correct env var name fix(back): correct AWS env var name Feb 13, 2024
@BertrandRenault
Copy link
Contributor Author

You right, it was not from pixano0.5.0b3 but local develop version. Issue has been edited accordingly

@BertrandRenault BertrandRenault merged commit 246c9f5 into develop Feb 13, 2024
5 checks passed
@cpvannier cpvannier added bug: major Major issues, significant user impact and removed bug: minor Minor issues, minimal user impact labels Feb 14, 2024
cpvannier pushed a commit that referenced this pull request Feb 15, 2024
@cpvannier cpvannier deleted the fix/wrong-s3-env-vars-request branch February 27, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: major Major issues, significant user impact scope: back Related to Pixano backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong env. vars requested after #93
3 participants