fix(front): reshape bbox with positive height/width #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BertrandRenault
added
invalid
BertrandRenault
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
used getClientRect({relativeTo: ...}) for better handling of rotated rect (resize out of object bounds does rotate 180 or -180) |
cpvannier
approved these changes
Feb 13, 2024
timothee-LJN
approved these changes
Feb 13, 2024
cpvannier
added
bug: minor
cpvannier
pushed a commit
that referenced
this pull request
Feb 15, 2024
* fix: reshape bbox with positive height/width * fix: better handling of rect creation/edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #118