-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Add loading animation in frontend UI #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As itemDetails interface has been deprecated: - handleSaveItemDetails() becomes handleSaveItem() - postItemDetails() becomes postDatasetItem()
As Library and LoadingLibrary now have a specific header, the main header should only be loaded if there is a selected dataset
As AnnotationWorkspace / ExplorationWorkspace load when selectedItem is not null, selectedItem should be assigned only at the end of handleSelectItem() when all processes are complete.
When waiting on something to be able to update the UI, add a loading modal consisting of a spinning progress circle. This currently includes: - loading an item - saving an item - loading the results of a semantic search model - loading an interactive segmentation model and its embeddings
Replace LoadingLibrary by a loading modal and merge it into Library
Config file needed for Tailwind CSS IntelliSense
cpvannier
added
enhancement
New feature or request
scope: front
Related to Pixano frontend
labels
Dec 6, 2023
BertrandRenault
approved these changes
Dec 6, 2023
Shorten lines for better display in the GitHub Releases
jrabary
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a loading animation in frontend user interface when loading or saving takes time. This currently includes:
Changes
Added
Fixed