fix(front): Do not add random transform shape after deleting an object #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BertrandRenault
approved these changes
Feb 15, 2024
cpvannier
added
bug: minor
cpvannier
approved these changes
Feb 15, 2024
cpvannier
pushed a commit
that referenced
this pull request
Feb 15, 2024
#150) * style(front): Remove dead code * fix(front): Remove rectangle from shape transformer when its destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #147
Description
The
transformeris the Konva object that allow modifying shape.When a rectangle is destroyed (removed from the DOM), it is always removed from the
Transformer