fix(back): inference_model: don't rely on db/media table order #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BertrandRenault
added
bug: minor
I think this PR should be merged now to fix the issue for Pixano 0.5.0, as RFC1 won't be implemented until Pixano 0.6.0. |
cpvannier
approved these changes
Feb 20, 2024
timothee-LJN
approved these changes
Feb 21, 2024
cpvannier
removed
bug: minor
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #168
Description
inference_model > _load_rows() doesn't rely on table order anymore
This PR is draft, for reference, as _load_rows() should use methods from Dataset class, which may depends on RFC1 rfcs/RFC1.md