Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): Improve autocomplete UX and placement #171

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

timothee-LJN
Copy link
Contributor

Issue

Fixes #159 and #157

Description

  • Reverted to a popover to display the feature list of the autocomplete feature as it allows placing the list on top of the app.
  • The combobox opens either on click or on keypress "enter" for keyboard users. I believe the UX is still performant.
  • Fixes tiny layout alignments
  • For now, when the user input a new value, it can be selected. All "intermediate" values are temporary saved. Eg. If I input "Balloon", "B", "Ba", "Ball"... "Balloon" will be temporary saved. It is only visible if the user erases its input. Once its closed, only the final input is saved. I decided it was ok and not to lose more time on this. I can improve that behavior if you think I should.
image

@timothee-LJN timothee-LJN self-assigned this Feb 20, 2024
@timothee-LJN timothee-LJN linked an issue Feb 20, 2024 that may be closed by this pull request
@timothee-LJN timothee-LJN merged commit fe8af17 into develop Feb 20, 2024
5 checks passed
@cpvannier cpvannier mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants