Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(front): Improve how stats are displayed in the app #172

Merged
merged 4 commits into from
Feb 20, 2024
Merged

fix(front): Improve how stats are displayed in the app #172

merged 4 commits into from
Feb 20, 2024

Conversation

ulysse-bonneau
Copy link
Member

Issue

Fixes #170

Description

  • Improved appearance and readability of histograms :
    image
  • Changed library from Vega-lite to Chart.js
  • Added a zoom feature
  • Responsiveness improved

@ulysse-bonneau ulysse-bonneau changed the title Feat/enhance histograms fix(front) Improve how stats are displayed in the app Feb 20, 2024
@ulysse-bonneau ulysse-bonneau added enhancement New feature or request scope: front Related to Pixano frontend priority: medium This item needs to be worked on soon labels Feb 20, 2024
timothee-LJN
timothee-LJN approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@timothee-LJN timothee-LJN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following conventionnal commit, your PR should be name
"fix(front): Improve ..."

https://www.conventionalcommits.org/en/v1.0.0/#summary

ui/components/core/src/components/Histogram.svelte Outdated Show resolved Hide resolved
ui/components/core/src/components/Histogram.svelte Outdated Show resolved Hide resolved
ui/components/core/src/components/Histogram.svelte Outdated Show resolved Hide resolved
ui/components/core/src/components/Histogram.svelte Show resolved Hide resolved
ui/components/core/src/components/Histogram.svelte Show resolved Hide resolved
@ulysse-bonneau ulysse-bonneau changed the title fix(front) Improve how stats are displayed in the app fix(front): Improve how stats are displayed in the app Feb 20, 2024
@ulysse-bonneau ulysse-bonneau merged commit 2c0140b into develop Feb 20, 2024
5 checks passed
@cpvannier cpvannier removed enhancement New feature or request scope: front Related to Pixano frontend priority: medium This item needs to be worked on soon labels Feb 28, 2024
@cpvannier cpvannier mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothee-LJN timothee-LJN timothee-LJN approved these changes

@cpvannier cpvannier cpvannier approved these changes

Assignees

@ulysse-bonneau ulysse-bonneau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve how stats are displayed in the app
3 participants
@ulysse-bonneau @cpvannier @timothee-LJN