Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): Fix Objects disappear on click in pre-annotation mode #180

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

BertrandRenault
Copy link
Contributor

@BertrandRenault BertrandRenault commented Feb 21, 2024

Issue

Fixes #156

Description

  • Put preAnnotationIsActive in store
  • prevent unwanted update of itemObjects when in pre-annotation mode

Also, remove annoying autofocus on feature input(s) in pre-annotation mode

@BertrandRenault BertrandRenault self-assigned this Feb 21, 2024
@BertrandRenault BertrandRenault added bug: minor Minor issues, minimal user impact scope: front Related to Pixano frontend labels Feb 21, 2024
@BertrandRenault BertrandRenault added this to the 0.5.0 milestone Feb 21, 2024
@BertrandRenault BertrandRenault marked this pull request as ready for review February 21, 2024 15:03
@BertrandRenault BertrandRenault changed the title fix(front): don't update itemObjects when preAnnotation active fix(front): Fix Objects disappear on click in pre-annotation mode Feb 21, 2024
@@ -36,6 +36,7 @@
export let formInputs: CreateObjectInputs = [];
export let objectProperties: { [key: string]: FeatureValues } = {};
export let initialValues: Record<string, ItemFeature> = {};
export let enableAutofocus: boolean = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe name it isAutofocusEnabled for clarity ?

@BertrandRenault BertrandRenault merged commit 2407f19 into develop Feb 22, 2024
5 checks passed
@cpvannier cpvannier removed bug: minor Minor issues, minimal user impact scope: front Related to Pixano frontend labels Feb 28, 2024
@cpvannier cpvannier removed this from the 0.5.0 milestone Feb 28, 2024
@cpvannier cpvannier mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-annotation: Highlighted object disappear on a click on image
3 participants