Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): Storybook not working #182

Merged
merged 15 commits into from
Feb 23, 2024
Merged

Conversation

ulysse-bonneau
Copy link
Member

@ulysse-bonneau ulysse-bonneau commented Feb 22, 2024

Issue

Fixes pixano/pixano-project-manager#25

Description

Storybook was not working properly :

  • Most stories were broken
  • Most CSS/Tailwind imports were broken

It is now fixed, and some stories were added, some others were reorganized for better navigation.

@ulysse-bonneau ulysse-bonneau added bug: minor Minor issues, minimal user impact scope: tests Related to Pixano unit tests and storybooks priority: medium This item needs to be worked on soon labels Feb 22, 2024
@ulysse-bonneau ulysse-bonneau self-assigned this Feb 22, 2024
ui/apps/pixano/src/routes/styles.css Outdated Show resolved Hide resolved
Copy link
Member

@cpvannier cpvannier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the changes made to the storybook, it seems most of the images in ui/tools/storybook/assets are unused and could be removed to reduce the repository size?

Also the description of this PR should be updated from Fixes #25 to Fixes pixano/pixano-project-manager#25 to refer to the correct issue.

@ulysse-bonneau ulysse-bonneau merged commit e14a138 into develop Feb 23, 2024
5 checks passed
@cpvannier cpvannier removed bug: minor Minor issues, minimal user impact scope: tests Related to Pixano unit tests and storybooks priority: medium This item needs to be worked on soon labels Feb 28, 2024
@cpvannier cpvannier mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants