Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): Use pan tool when editing object #195

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

timothee-LJN
Copy link
Contributor

Issue

Fixes #189

Description

  • add selectedTool to DatasetItemWorkspaceStore
  • use PAN when switching to edit mode

@timothee-LJN timothee-LJN merged commit b77a795 into develop Feb 28, 2024
5 checks passed
@cpvannier cpvannier mentioned this pull request Feb 29, 2024
timothee-LJN added a commit that referenced this pull request Mar 22, 2024
* feat(front): Add selection tool to store

* feat(front): Use pan tool when switching object to edit mode
BertrandRenault added a commit that referenced this pull request Apr 22, 2024
* feat(front): Adding mock video

* feat(front): video player POC

* feat(front): Play video in canvas2D

* feat(front): Play video in canvas

* feat(front): Click on player to move video

* feat(front): Add styling to player

* feat(front): Improve player

* feat(front): Improve video timer design

* fix(front): Fix jerky drag and drop behavior

* feat(front): Allow zooming in time player

* feat(front): Allow zoom in and out in time scale

* fix(front): Fix click on zoomed in player

* feat(front): Scroll vertically when player is playing

* feat(front): Add slider to change zool level

* fix(front): Remove glitch when playing video

* fix: Remove console.log statement in onMount()

* refactor(front): Create VideoPlayer component

* refactor(front): Create VideoApi file and migrate function in there

* feat(front): Add multi image views for videos

* fix(front): Fixing linting issues in models module

* feat(front): Load image from server - mock for now

* refactor(front): Remove dead code in Canvas2D

* feat(front): Add experimental bbox moving

* feat(front): Improve player layout

* feat(front): Objects display - wip

* feat(front): Add context component

* feat(front): Display fake coordinates

* fix(front): Add selection and color params to video Viewer

* feat(front): Highlight object on right click

* feat(front): Right click select an object and change timestamp

* feat(front): Create time track component

* feat(front): Save edition of inflexion point - wip

* feat(front): Update and simplify data structure

* feat(front): Delete inflexion point

* feat(front): Add a new point

* feat(front): Change in API for breakPoints to allow null interval

* fix(front): Fix delete breakpoint function

* feat(front): Update all object track after object is deleted

* fix(front): Fix editing breakpoint coords

* feat(front): Hide object when off interval

* feat(front): Add point

* feat(front): Improve new point location accurency

* fix(front): Add correct coords to breakpoints interval

* fix: Fix z-index in time track

* feat(front): Improve layout in time tracker

* create VideoPlayerRow component for better layout

* add object color in video player

* add border in between player element

* rework z-index on player

* change time track needle style

* fix drag me function on timeTrack

* improve display of digit in time track

* fix add breakpoint coordinates

* Fix linearInterpolation function in videoApi.ts

* Remove console.log statement in videoApi.ts

* add border in gap between name and timeTrack section

* play pause takes new time position  after drag or time track click

* Refactor VideoPlayer component styles and z index

* hide time needle when scrolling horizontally

* fix: start object time track at left zero

* rename objectTimeTrack

* Refactor VideoPlayerRow component to use isTopRow prop

* highlight object being edited

* highlight breakpoint being edited

* fix: edit last breakpoint if greater than lastFrameIndex

* unselect breakpoint when finish editing

* create object interval component

* use box breakpoint interval in interval component

* drag breakpoint to change interval size POC

* cleaning up unused variables

* add limits to drag and dropping breakpoint

* refacto update interval width function

* fix: allow drag and dropping to limits of intervals

* Add findNeighbors function to videoApi

* improve limits to new interval width

* create new interval when adding a breakpoint on an empty section

* Refactor video viewer and object time track components

* refacto first round

* rename datasetType to datasetItemType

* allow editing keybox

* add point click

* rename components and function to match new api

* allow dragging keybox to max edge

* sort outlet when creating new ones

* storybook work wip

* display video in storybook

* add better mock

* fix adding a point to tracklet

* improve object highlighting when editing

* hide box being edited

* scale box size depending on time scale

* storybook improvment

* fix image storybook

* fix storybook with correct images size

* select starting box when editing object from inspector

* allow splitting tracklet

* allow deleting tracklet

* Remove console.log statements

* fix(front): Use pan tool when editing object (#195)

* feat(front): Add selection tool to store

* feat(front): Use pan tool when switching object to edit mode

* remove dead code

* edit point after its added

* fix linting issues

* Update tsconfig.json and context-menu components style

* remove comment

* simplify table component

* clean table

* fix(ci): use pnpm version 9

* fix(front): prettier format

* fix table in pixano app

* fix select item in table

* change storybook architecture

---------

Co-authored-by: ulysse-bonneau <ulysse.bonneau@proton.me>
Co-authored-by: brenault <bertrand.renault@cea.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deselect inter-active tools when edit object is enable
3 participants